Skip to content

improve: dependent configuration improvements #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 44 commits into from
Closed

improve: dependent configuration improvements #2384

wants to merge 44 commits into from

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented May 15, 2024

No description provided.

csviri and others added 30 commits April 10, 2024 15:51
@csviri
chore: set version to 5.0.0-SNAPSHOT (#2200)
77b74c5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: java version minimal 11, tested on 21 (#2207)
5d79fb5 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated EventFilter (#2208)
2dcf2de 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
docs: 5.0 migration guide skeleton (#2210)
8b32d7a 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: managed dependent reconciliation results not optional (#2212)
4affda3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: remove deprecated RetryConfiguration (#2211)
59946f7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: JDK client is now the default (#2235)
4bcd969 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
fix: update SCM information (#2237)
30d82f3 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
d730ed0 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <csviri@gmail.com>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>

---------

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
format
db26f43 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
fix: test after rebase on master (#2270)
66f14f4 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: use java 17 as baseline (#2271)
bff9674 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: matcher always considers metadata (#2273)
c8ff7de 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: API to check if next reconciliation is imminent (#2272)
2417c5c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
c801910 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
fix: pom properties cleanup (#2280)
307c159 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
4875c08 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@metacosm
refactor: make loadFromProperties private (#2287)
71a14cf 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
3b393e3 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: explicit workflow invocation (#2289)
4c8fd7b 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
2c66093 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
refactor: make WorkflowSpec an interface (#2300)
b4c6c75 
Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
improve: replace current formatting plugins with spotless plugin (#2302)
c14f19c 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
80aab73 
…2308)

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
fix: package fix leader election sample (#2303)
ff24d83 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: remove resource discriminator (#2299)
8ac396e 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
ea38e17 
…ed (#2297)

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
improve: additional logging to mysql schema e2e test (#2320)
2b9a3ac 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
3610960 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
feat: using SSA for finalizer and primary patch (#2305)
a40cea2 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri and others added 14 commits April 11, 2024 16:49
@csviri @metacosm
fix: error with java docs validation (#2336)
6ec4839 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
fix: format after rebase
76046f7 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
fix: remove now unneeded okhttp dependency override, wrong comment (#…
71e5185 
…2331)

Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
feat: run spotless on compile (#2330)
ea1a06b 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
@metacosm @csviri
refactor: clean-up (#2325)
a08d725 
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Attila Mészáros <csviri@gmail.com>
@csviri
improve: samples correctly create status object for SSA (#2365)
69ee626 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
improve: named event sources and related changes (#2340)
db61dfb 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri @metacosm
feat: silent exception handling in managed workflows (#2363)
b77905e 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
feat: feature flag to not clone secondary resource on access (#2364)
6897669 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri
fix: unit test for event processor stopping (#2373)
5ab2658 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: all event source is resource event source (#2367)
fd8c2c9 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
feat: read-only bulk dependent (#2372)
6d7b71c 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
@csviri @metacosm
feat: remove automatic observed generation handling (#2382)
5bf3e91 

Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Co-authored-by: Chris Laprun <claprun@redhat.com>
@csviri
improve: dependent configuration improvements
fb76f59 
Signed-off-by: Attila Mészáros <csviri@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
This was linked to issues May 15, 2024
Use composition instead interfaces for dependent behavior settings in v5 #1930
Closed
Refactor @KubeDependent and setting EventSource name explicitly from Dependent config #2361
Closed
@csviri csviri self-assigned this May 15, 2024
@csviri csviri force-pushed the next branch 2 times, most recently from 88c4960 to afe3d7d Compare May 17, 2024 10:46
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 18, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@csviri
Copy link
Collaborator Author

csviri commented May 20, 2024

replaced by: #2389

@csviri csviri closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@csviri csviri

Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
3 participants
@csviri @openshift-merge-robot @metacosm